Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add server version if available and subcommand #5457

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

haarchri
Copy link
Contributor

@haarchri haarchri commented Mar 6, 2024

Description of your changes

  • add crossplane server version if available in cli
  • switch to subcommand for version
./crank version
Client Version: v1.15.0
Server Version: v1.15.0-up.1
./crank version
Client Version: v1.15.0
Server Version: v1.15.0
./crank version --client
Client Version: v1.15.0

Fixes #5447

I have:

Need help with this checklist? See the cheat sheet.

@haarchri haarchri requested review from phisco and a team as code owners March 6, 2024 15:47
@haarchri haarchri requested a review from bobh66 March 6, 2024 15:47
@haarchri haarchri force-pushed the feature/cli-cluster-version branch from e6e1267 to 74a6269 Compare March 6, 2024 16:03
cmd/crank/main.go Outdated Show resolved Hide resolved
cmd/crank/common/version.go Outdated Show resolved Hide resolved
@haarchri haarchri requested review from phisco and negz March 6, 2024 21:25
cmd/crank/common/version.go Outdated Show resolved Hide resolved
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise LGTM. Thanks!

@haarchri haarchri force-pushed the feature/cli-cluster-version branch from bcb60d0 to bd75081 Compare March 15, 2024 12:04
@haarchri haarchri changed the title feat(cli): add server version if available feat(cli): add server version if available and subcommand Mar 15, 2024
@haarchri haarchri force-pushed the feature/cli-cluster-version branch from bd75081 to 3bf86e7 Compare March 15, 2024 14:00
@haarchri
Copy link
Contributor Author

switched to subcommand for version and did all suggestions @negz

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new FetchCrossplaneVersion implementation looks great, but I have some questions about the CLI arg/flag handling code.

cmd/crank/main.go Outdated Show resolved Hide resolved
cmd/crank/main.go Outdated Show resolved Hide resolved
cmd/crank/version/version.go Outdated Show resolved Hide resolved
cmd/crank/version/version.go Outdated Show resolved Hide resolved
@haarchri haarchri force-pushed the feature/cli-cluster-version branch from 3bf86e7 to d5c41d0 Compare April 3, 2024 13:41
@haarchri haarchri requested a review from negz April 3, 2024 13:45
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions / nits but mostly LGTM. Approving to unblock.

cmd/crank/main.go Outdated Show resolved Hide resolved
cmd/crank/version/fetch.go Outdated Show resolved Hide resolved
cmd/crank/version/version.go Outdated Show resolved Hide resolved
cmd/crank/version/version.go Outdated Show resolved Hide resolved
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri force-pushed the feature/cli-cluster-version branch from 7b072e0 to d7d778c Compare April 4, 2024 08:27
@negz negz merged commit 32e164d into crossplane:master Apr 4, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crossplane cli --version client and server version
3 participants