-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add server version if available and subcommand #5457
Conversation
e6e1267
to
74a6269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion but otherwise LGTM. Thanks!
bcb60d0
to
bd75081
Compare
bd75081
to
3bf86e7
Compare
switched to subcommand for version and did all suggestions @negz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new FetchCrossplaneVersion
implementation looks great, but I have some questions about the CLI arg/flag handling code.
3bf86e7
to
d5c41d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions / nits but mostly LGTM. Approving to unblock.
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
7b072e0
to
d7d778c
Compare
Description of your changes
Fixes #5447
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR.Need help with this checklist? See the cheat sheet.