Allow kubernetes service annotations #5471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtzeDeVries
force-pushed
the
allow-service-annotations
branch
from
f3c9c87
to
530a34a
Compare
negz
reviewed
Mar 13, 2024
Allow setting annotations on the kubernetes service object. In GPC we need annotations to expose a service as a NEG which is required in order for the k8s controlplane to reach the webhook. This pr will add the ability to add annotations to the service object Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
AtzeDeVries
force-pushed
the
allow-service-annotations
branch
from
33a3c24
to
3a9740c
Compare
|
@AtzeDeVries We typically only back port bug fixes. If it's easy for you to use the updated Helm chart with 1.15 until we release 1.16 that would be my preference. |
negz
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Allow setting custom annotations on the service object. For GCP we require a
NEG when using webhooks. Setting up the NEG requires annotations on the
service object.
I cannot add labels, but prefer backport to 1.13
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.