Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default max reconcile rate and resource limits #5478

Merged
merged 1 commit into from Mar 14, 2024

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Mar 14, 2024

Description of your changes

This PR:

  • bumps the default max reconcile rate from 10 to 100.
  • bumps the default cpu limit 100m to 500m
  • bumps the default memory limit from 512Mi to 1024Mi

To improve the performance with default settings as discussed here and here.

Please note that these are just defaults for still configurable values which could still be reverted to the previous values if needed for certain cases/reasons.

I have:

Need help with this checklist? See the cheat sheet.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks inline with the previous discussions, thanks @turkenh! ✅

Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh merged commit 40f0a29 into crossplane:master Mar 14, 2024
17 checks passed
Copy link

Backport failed for release-1.13, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.13
git worktree add -d .worktree/backport-5478-to-release-1.13 origin/release-1.13
cd .worktree/backport-5478-to-release-1.13
git switch --create backport-5478-to-release-1.13
git cherry-pick -x 76fdf072330959e526a3a2435321b6a08829212e

Copy link

Backport failed for release-1.14, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.14
git worktree add -d .worktree/backport-5478-to-release-1.14 origin/release-1.14
cd .worktree/backport-5478-to-release-1.14
git switch --create backport-5478-to-release-1.14
git cherry-pick -x 76fdf072330959e526a3a2435321b6a08829212e

Copy link

Backport failed for release-1.15, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.15
git worktree add -d .worktree/backport-5478-to-release-1.15 origin/release-1.15
cd .worktree/backport-5478-to-release-1.15
git switch --create backport-5478-to-release-1.15
git cherry-pick -x 76fdf072330959e526a3a2435321b6a08829212e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants