Add missing scrape annotations to provider pods #5529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
All crossplane providers expose metrics by default, the ones inherited from controller runtime at minimum. In provider pods, the package manager adds the
metrics
port already but don't add the Prometheus scrape annotations, which would be convenient for observing providers without additional configuration.This PR adds the following annotations to all provider pods by default:
It is possible to disable this behavior with a
DeploymentRuntimeConfig
as below:We are already adding these annotations to Crossplane and RBAC manager pods.
I have:
make reviewable
to ensure this PR is ready for review.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.backport release-x.y
labels to auto-backport this PR.Need help with this checklist? See the cheat sheet.