Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --context option to crossplane cli beta trace command #5542

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

padlar
Copy link
Contributor

@padlar padlar commented Apr 3, 2024

Allows the user to run trace command without switching Kubernetes context.

Description of your changes

Fixes #5537

I have:

Need help with this checklist? See the cheat sheet.

Allows the user to run trace command without switching Kubernetes
context.

Signed-off-by: Sunil Shivanand <padlar@live.com>
@padlar padlar requested review from phisco and a team as code owners April 3, 2024 22:20
@padlar padlar requested a review from turkenh April 3, 2024 22:20
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @padlar!

@phisco phisco merged commit 9568f16 into crossplane:master Apr 4, 2024
14 of 16 checks passed
@jbw976
Copy link
Member

jbw976 commented Apr 4, 2024

was just thinking if there were other commands this could also benefit fro a --context argument. I think maybe crossplane beta top would be the only one?

all current commands:

  xpkg build        Build a new package.
  xpkg install      Install a package in a control plane.
  xpkg login        Login to the default package registry.
  xpkg logout       Logout of the default package registry.
  xpkg push         Push a package to a registry.
  xpkg update       Update a package in a control plane.
  beta convert deployment-runtime
                    Convert a ControllerConfig to a DeploymentRuntimeConfig.
  beta convert pipeline-composition
                    Convert a Patch-and-Transform Composition to a Function
                    Pipeline Composition.
  beta render       Render a composite resource (XR).
  beta top          Display resource (CPU/memory) usage by Crossplane related
                    pods.
  beta trace        Trace a Crossplane resource to get a detailed output of its
                    relationships, helpful for troubleshooting.
  beta xpkg init    Initialize a new package from a template.
  beta validate     Validate Crossplane resources.

@brovoca
Copy link

brovoca commented Apr 4, 2024

Really nice to see this incorporated this quick! Waiting for next release 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --context Parameter Support to crossplane beta trace Command
4 participants