Add functions to init container for helm chart deployment #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
phisco
approved these changes
Apr 17, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.15
git worktree add -d .worktree/backport-5586-to-release-1.15 origin/release-1.15
cd .worktree/backport-5586-to-release-1.15
git switch --create backport-5586-to-release-1.15
git cherry-pick -x cf3885087cb47aefee892dffb8a5dfadb21405a5 |
|
Is this not the same functionality as #5539? Is there a reason that earlier PR did not move forward, or was it just an oversight here? 🤔 |
|
Mhm :( #5539 was approved btw |
|
My apologies @haarchri - I should have seen and merged your PR. I will work to clean up the PR backlog so I don't make the same mistake again. |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added support for deploying functions along with the Crossplane Helm Chart, using the same logic that
is used for Providers and Configurations.
Fixes #5541
I have:
make reviewableto ensure this PR is ready for review.- [ ] Added or updated e2e tests.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.
Tested these changes using a helm deployment to include
function-auto-readyin the deployed set of packages.