Bump crossplane-runtime to v1.17.0-rc.0

[jbw976]

Description of your changes

This PR simply bumps the crossplane-runtime dependency to v1.17.0-rc.0, as per the code freeze steps in crossplane/release#9, specifically:

(On the Master Branch) created and merged a PR bumping the Crossplane Runtime dependency to the release candidate tag from master, vX.Y+1.0-rc.0.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable to ensure this PR is ready for review.
• Added or updated unit tests.
• Added or updated e2e tests.
• Linked a PR or a docs tracking issue to document this change.
• Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

[jbw976]

Hmm, looks like check-diff is failing with these new changes from crossplane-runtime, I'll need to look into that:

08:14:51 [FAIL] There are uncommitted changes after running make generate. Please ensure you commit all generated files in this branch after running make generate.
make: *** [build/makelib/common.mk:446: check-diff] Error 1

https://github.com/crossplane/crossplane/actions/runs/8981967983/job/24668568512?pr=5652

[jbw976]

@phisco @turkenh this is ready for review again - I've addressed the check-diff failure simply by running make generate 😇

[jbw976]

Hmm, the same e2e test failed in 2 different suites, which I don't personally know to be flaky:

--- FAIL: TestConfigurationWithDependency (93.18s)
    --- FAIL: TestConfigurationWithDependency/TestConfigurationWithDependency (93.18s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/ConfigurationIsHealthy (6.00s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/RequiredProviderIsHealthy (12.50s)

• https://github.com/crossplane/crossplane/actions/runs/8982305584/job/24669624198?pr=5652
• https://github.com/crossplane/crossplane/actions/runs/8982305584/job/24669625481?pr=5652

I'll investigate this error locally before proceeding 🤓

[jbw976]

I'm unable to repro this e2e test failure locally after running it a handful of times:

❯ make e2e E2E_TEST_FLAGS="-test.v -test.failfast -fail-fast -destroy-kind-cluster=false --kind-logs-location ./logs-kind --test-suite base -test.run ^TestConfigurationWithDependency"
...
--- PASS: TestConfigurationWithDependency (21.11s)
    --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency (21.11s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/ConfigurationIsHealthy (11.01s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/RequiredProviderIsHealthy (8.51s)
PASS
11:08:49 [ OK ] Run E2E tests

In the runs here on this PR, it looks like the provider-nop was unable to be deleted, but it's not clear why:

    env.go:428: Deleted resources from test/e2e/manifests/pkg/configuration/dependency/provider-dependency.yaml (matched 1 manifests)
    env.go:428: Waiting 1m0s for Provider.pkg.crossplane.io crossplane-contrib-provider-nop to be deleted...
W0507 08:47:11.905335    6012 warnings.go:70] v1 ComponentStatus is deprecated in v1.19+
W0507 08:47:24.096660    6012 warnings.go:70] ControllerConfig.pkg.crossplane.io/v1alpha1 is deprecated. Use DeploymentRuntimeConfig from pkg.crossplane.io/v1beta1 instead.
    env.go:428: resources not deleted: context deadline exceeded:

I don't see a deletion timestamp on the Provider or ProviderRevision objects in the test debug output, which is odd. I don't see immediate evidence they are undergoing a deletion attempt, even though it says we did request a deletion above 🤔

The same test is passing on a similar PR that bumps crossplane-runtime in the release branch: https://github.com/crossplane/crossplane/actions/runs/8982458339/job/24670118653?pr=5653. So perhaps this test is flaky - something to look more into but perhaps not blocking this specific PR.

[jbw976]

Plenty of instances of this same failure previously in master before this PR:

• https://github.com/crossplane/crossplane/actions/runs/8907369180/job/24461107547
• https://github.com/crossplane/crossplane/actions/runs/8840831793/job/24276868974
• https://github.com/crossplane/crossplane/actions/runs/8835618736/job/24260221508

I'll take a note of the flaky tests we're seeing and capture it in an issue so we can improve on them, but I don't think this is blocking this PR 😌

[phisco]

Yes, we can address this before the release. I agree it shouldn't block the code freeze process