feat(transforms): Add docs for string join transform #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
MisterMX
force-pushed
the
feat/transform-string-join
branch
from
1776915
to
02604f2
Compare
plumbis
requested changes
Dec 29, 2023
| @@ -1654,6 +1655,25 @@ patches: | |||
| trim: `-north-1' | |||
| ``` | |||
|
|
|||
| #### Join | |||
There was a problem hiding this comment.
Can you move this section to be before line 1601, the heading "Regular expression type" to make the type order alphabetical?
| #### Join | ||
|
|
||
| The {{<hover label="typeJoin" line="8">}}type: Join{{</hover>}} joins all | ||
| values in the input array into a string using the given separator. |
There was a problem hiding this comment.
Suggested change
| values in the input array into a string using the given separator. | |
| values in the input array into a string using the given separator. |
I'd suggest adding a line break to put the line "This transform only works..." on a new line.
| {{<hover label="string" line="7">}}types{{</hover>}} | ||
|
|
||
| * [Convert](#string-convert) | ||
| * [Format](#string-format) | ||
| * [Regexp](#regular-expression-type) | ||
| * [TrimPrefix](#trim-prefix) | ||
| * [TrimSuffix](#trim-suffix) | ||
| * [Join](#join) |
There was a problem hiding this comment.
Can you move this to be the third item in the list so it's alphabetical?
|
_ping _ @MisterMX |
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
feat/transform-string-join
branch
from
02604f2
to
9d88c47
Compare
|
@plumbis I applied your requested changes. Can you take a second look? |
plumbis
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.