This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Fix unstable e2e test of dependency engine #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: My-pleasure <dearqwq@qq.com>
wonderflow
reviewed
Jul 23, 2020
| @@ -204,7 +204,7 @@ var _ = Describe("Resource Dependency in an ApplicationConfiguration", func() { | |||
| func() error { | |||
| return k8sClient.Get(ctx, inFooKey, inFoo) | |||
| }, | |||
| time.Second*15, time.Millisecond*500).Should(BeNil()) | |||
| time.Second*60, time.Second*5).Should(BeNil()) | |||
There was a problem hiding this comment.
polling interval set to 1s would be better?
There was a problem hiding this comment.
ok, and then the timeout value should be bigger? Because last time, it failed when timeout is 60s, polling interval is 5s.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the instability of e2e test is mainly in these two places after the dependency conditions are satisfied:
So I expand Eventually's timeout and polling interval in these two places.
(By the way, I update CRD version to v1 instead of v1beta1.)