This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
fix status automatically removed bug #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
fix-status
branch
2 times, most recently
from
5717426
to
d72da93
Compare
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
ryanzhang-oss
force-pushed
the
fix-status
branch
from
d72da93
to
98cdad2
Compare
hongchaodeng
approved these changes
Sep 19, 2020
| @@ -346,10 +345,36 @@ func (r *OAMApplicationReconciler) updateStatus(ctx context.Context, ac *v1alpha | |||
| } | |||
| } | |||
| ac.Status.Workloads = append(ac.Status.Workloads, revisionStatus...) | |||
|
|
|||
| // patch the extra fields in the status that is wiped by the Status() function | |||
There was a problem hiding this comment.
Status() is not specific enough to pinpoint the code location.
Better point out its parent function/object as well.
wonderflow
reviewed
Sep 19, 2020
pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration.go
Show resolved
Hide resolved
|
The Coverage seems to have some problem, merging |
xishengcai
pushed a commit
to xishengcai/oam-kubernetes-runtime
that referenced
this pull request
Oct 25, 2020
fix status automatically removed bug Signed-off-by: Xisheng Cai <xishengcai@XishengdeMacBook-Pro.local> Signed-off-by: caixisheng <cc710917049@163.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status fields in the workload disappear after a reconcile loop. The culprit is that the controller runtime merge function doesn't know how to patch a simple Json object... The solution is to manually patch it on the clientside (lame)