This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
minor tweak, assign the workloadRef during render instead of apply #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
ryanzhang-oss
force-pushed
the
refactor
branch
from
28f37a3
to
3ef9849
Compare
wonderflow
approved these changes
Oct 15, 2020
wonderflow
reviewed
Oct 15, 2020
| trait := traits[i] | ||
| workloadRefPath := traitDef.Spec.WorkloadRefPath | ||
| if len(workloadRefPath) != 0 { | ||
| fmt.Printf("\n\n\nworkloadRef path = %s\n\n\n", workloadRefPath) |
There was a problem hiding this comment.
please remove this debug info
There was a problem hiding this comment.
done, good catch
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
ryanzhang-oss
force-pushed
the
refactor
branch
from
e2297af
to
751f6d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign the workloadRef during render instead of apply phase. The result is a more clean-cut division between apply and render and one search for the traitDefinition instead of two.