Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicediscovery): added privatednsnamespace API and controller … #627

Merged
merged 1 commit into from May 24, 2021
Merged

feat(servicediscovery): added privatednsnamespace API and controller … #627

merged 1 commit into from May 24, 2021

Conversation

blut
Copy link

@blut blut commented Apr 13, 2021

…for AWS servicediscovery

Signed-off-by: Hannes Blut hannes.blut-extern@deutschebahn.com
(external expert on behalf of DB Netz AG)

Description of your changes

  • Added generated API code and controllers for AWS servicediscovery
  • Added resource type: PrivateDNSNamespace

Fixes # #562

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Testing has thus far been done manually to establish a first servicediscovery controller and functional requirements.
Unit tests will follow after the resource handling has been discussed

apis/servicediscovery/v1alpha1/custom_types.go Outdated Show resolved Hide resolved
apis/servicediscovery/v1alpha1/generator-config.yaml Outdated Show resolved Hide resolved
…icediscovery

Signed-off-by: blut <hannes.blut-extern@deutschebahn.com>
(external expert on behalf of DB Netz AG)
@blut
Copy link
Author

blut commented Apr 30, 2021

Squashed all commits

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for late review. There are a couple of things that would be good to fix but I'll merge this PR and open another one to fix them since this PR has been up for a long time now.

@muvaf muvaf merged commit 6c9f2cc into crossplane-contrib:master May 24, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
aws.acm-pca: disable certificateauthority tests since they cost too much
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants