Replication Group missing cross-resource referencers #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hasheddan
reviewed
Jan 2, 2020
negz
approved these changes
Jan 6, 2020
muvaf
force-pushed
the
replicationreferences
branch
from
dd6d860
to
3f74c67
Compare
… and security group name fields Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
muvaf
force-pushed
the
replicationreferences
branch
from
3f74c67
to
c97f12c
Compare
@hasheddan I've tested this manually and it resolves the correct name from the reference. Though for the VPC mode to work, we need to implement a managed resource @negz I think that's ready to merge. |
|
Thanks @muvaf, and @hasheddan for reviewing! |
wolffbe
pushed a commit
to wolffbe/provider-aws
that referenced
this pull request
Feb 12, 2021
…nces Replication Group missing cross-resource referencers
namku
pushed a commit
to namku/provider-aws
that referenced
this pull request
Mar 9, 2021
…nces Replication Group missing cross-resource referencers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds security group name referencer for
CacheSecurityGroupNameand security group ID referencer forSecurityGroupIDsfields. The reason that there are two different fields is thatCacheSecurityGroupNameis used in EC2-Classic mode andSecurityGroupIDsis used in EC2-VPC mode.Fixes #83
Checklist
I have:
make reviewableto ensure this PR is ready for review.app.yamlto include any new role permissions.