This repository has been archived by the owner on Oct 22, 2019. It is now read-only.
Refactor #3
Merged
Refactor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TimonPost
commented
Sep 26, 2019
•
TimonPost
commented
- book -> lib.rs
- removed /src/input/input.rs
- some namespace refactoring
- added some examples and made them compile
- ITerminalInput -> Input
- removed unsafe code
- handled tab WinApi property
zrzka
reviewed
Sep 30, 2019
src/input.rs
Outdated
| #[cfg(unix)] | ||
| mod unix_input; | ||
| pub(crate) mod unix_input; |
There was a problem hiding this comment.
Would be nice to follow style of what we're doing now here - drop the _unix suffix here.
There was a problem hiding this comment.
This 👍 means okay, but in another PR?
zrzka
reviewed
Sep 30, 2019
src/input/windows_input.rs
Outdated
| @@ -41,7 +44,7 @@ const ENABLE_MOUSE_MODE: u32 = 0x0010 | 0x0080 | 0x0008; | |||
| // NOTE (@imdaveho): this global var is terrible -> move it elsewhere... | |||
| static mut ORIG_MODE: u32 = 0; | |||
There was a problem hiding this comment.
Can we fix the static mut in this PR as well?
There was a problem hiding this comment.
Review re-requested, but it's still there. Does it mean that it will be in another PR?
43 tasks
|
LGTM except couple of things:
|
|
Sorry, I figured the up-to-date code was not yet pushed. |
zrzka
approved these changes
Oct 1, 2019
| @@ -38,10 +42,29 @@ impl WindowsInput { | |||
|
|
|||
| const ENABLE_MOUSE_MODE: u32 = 0x0010 | 0x0080 | 0x0008; | |||
|
|
|||
| // NOTE (@imdaveho): this global var is terrible -> move it elsewhere... | |||
| static mut ORIG_MODE: u32 = 0; | |||
| lazy_static! { | |||
There was a problem hiding this comment.
Can we move this & ENABLE_MOUSE_MODE above the pub(crate) struct WindowsInput; line? Just to keep constants, statics, ... at the "top" (below imports & modules).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.