API Cleanup 2

[zrzka]

Take this one as a Cleanup 2 rather than API Cleanup 2.

Changes

• Some tests weren't in a separate tests module
• ErrorKind::source wasn't returning all error sources
• New macro to implement From for ErrorKind
• Removed redundant From<&'a str> & From<String> for Color
  • If you have both, you can use FromStr
• Some Color tests added
• Removed Result from get_available_color_count & simplified
• Style macros reformatting & cleanup
• Style ObjectStyle cleanup (derive Default, etc.)
• Some docstring examples tests fixed & reenabled
• Sync/fix tests modules (mod test -> mod tests)
• Added missing empty lines between fns
• #[inline] replaced with #[inline(always)]
  • The intention was to always inline, right?
  • Reference
  • I'd keep this decision on the compiler and would probably remove it completely
• AsyncReader::stop_reading() renamed to stop()
• RawScreen::disable_raw_mode_on_drop renamed to keep_raw_mode_on_drop
  • It was a wrong name, with an opposite meaning
• Other various reformatting & cleanup

unwrap()s

• Removed unwrap() & expect() from everywhere
• The only crate with unwrap() calls is the crossterm_input
  • Not going to solve it in this PR, because I have to think about it as there's threading, channels, ... involved

[TimonPost]

To my opinion it is more clear if we use ObjectStyle, especially in macros where type inspection with idea is a pain.

[zrzka]

Kind of disagree here. It's a standard pattern. See the documentation and an example:

fn main() {
    let options = SomeOptions { foo: 42, ..Default::default() };
}

[TimonPost]

In that case, I can find my way in. In this case, we have a macro for which we don't have a type of inspection or highlighting for a lot of IDEs. ObjectStyle::default()is much more specific than Deafault::default()`, so someone who reads this macro can better understand what it says. So it's more about readability and being specific in macros.

[zrzka]

The macro looks like this ...

StyledObject {
    object_style: ObjectStyle { // <-- here
        $side: Some($color),
        ..Default::default()
    },
    content: self
}

... and you have the ObjectStyle 2 lines above the ..Default::default(), which looks enough & fine to me.

There's also a similar case in the macro below (def_str_attr) ...

StyledObject {
    object_style: Default::default(),
    content: self,
}

... where Default::default() is used, but there's no ObjectStyle at all. Which is, from the readability point of view a bit worse than the first case.

I do not want to force my opinion here, both ways can be used, so, I'll change it.

[zrzka]

Ouch, merged while I was typing. I assume that there's no need to change it once it is already merged.

[TimonPost]

No, I am fine with it. Isn't that big of a deal. Otherwise, I wouldn't have merged it.

[TimonPost]

Looks good, there is no blocker