Unit tests #242
Merged
Unit tests #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrzka
reviewed
Sep 21, 2019
| @@ -130,7 +129,6 @@ mod tests { | |||
|
|
|||
| // TODO - Test is ingored, because it's stalled on Travis CI | |||
| #[test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
These don't work on TCI, should be disabled. See the comment above (in the code).
There was a problem hiding this comment.
Yea I saw the comments, just wanted to try it again. Unfortunately...
| @@ -128,8 +128,12 @@ impl ITerminal for WinApiTerminal { | |||
| resize_buffer = true; | |||
| } | |||
|
|
|||
| println!("{:?}", new_size); | |||
|
BTW you can run ignored tests locally by adding |
|
On mobile, can't find the Approve button, so, approved :D |
december1981
pushed a commit
to december1981/crossterm
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased get terminal size by one (corrected change)
Decreased set terminal size windows by 1. Windows starts counting from 0, when setting the size to 5, 5 windows will see that as 6,6, therefore we need to subtract 1.
removed ignores from test