Automatically close raw fd when finished using #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compenguy
added a commit
to compenguy/panharmonicon
that referenced
this pull request
Mar 4, 2020
Downgrading cursive because it forces (gyscos/cursive#432) upgrading to a version of crossterm that leaks filehandles rapidly enough to reach the process limit in a few minutes (crossterm-rs/crossterm#383).
fdehau
pushed a commit
to fdehau/tui-rs
that referenced
this pull request
Mar 12, 2020
This will prevent [this](crossterm-rs/crossterm#383) descriptor leak bug when people use the crossterm backend with the current master.
sayanarijit
pushed a commit
to ratatui-org/ratatui
that referenced
this pull request
Mar 3, 2023
This will prevent [this](crossterm-rs/crossterm#383) descriptor leak bug when people use the crossterm backend with the current master.
december1981
pushed a commit
to december1981/crossterm
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the terminal size will leak a file descriptor currently. (#382)
This uses the auto-closing logic to avoid this issue.