Refactored winapi and moved code to (crossterm_winapi) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the whole WinApi to make it more robust whit error handling. I moved some logic to its own crate
crossterm_winapiwhy did I do this? I did this because of a future idea I have about having the option to use all cross-term modules separate from each other, they will be basically their own crate. So I started whit abstracting away some code so that it is easier to reuse it later in other crates. Also, this enables non-cross-term users to use my WinApi abstractions.Currently, I have focused on removing all the unwraps according to #40 by bubbling them all up. However, I had to stop at some point because I needed to change the user API, because of that I want to have it in a separate PR.