Capture double click mouse events on Windows #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When double clicking on Windows, the crossterm_winapi emits the first click with `EventFlags::PressOrRelease` and the second click with `EventFlags::DoubleClick`. Previously this code explicitly ignored mouse events with `EventFlags::DoubleClick` because "double click not supported by unix terminals." This change captures the double click and surfaces them as normal click events.
stphnt
force-pushed
the
capture-double-click-events
branch
from
bfd9257
to
387dd6c
Compare
stphnt
changed the title
TimonPost
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #825
When double clicking on Windows, the crossterm_winapi emits the first click with
EventFlags::PressOrReleaseand the second click withEventFlags::DoubleClick. Previously this code explicitly ignored mouse events withEventFlags::DoubleClickbecause "double click not supported by unix terminals." This change captures the double click and surfaces them as normal click events.