Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If ioctl TIOCGWINSZ returns 0,0 try to use env vars instead. #893

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

If ioctl TIOCGWINSZ returns 0,0 try to use env vars instead. #893

wants to merge 2 commits into from
+9 −1

Commits on May 17, 2024

  1. If ioctl TIOCGWINSZ returns 0,0 try to use env vars instead. 

    For some terminals (for example Emacs eshell/eterm) the ioctl with
TIOCGWINSZ might falsely return 0 columns and 0 rows.  If this happens
we now try to use LINES and COLUMNS environment variables.

Fixes crossterm-rs#891
    @swilde
    swilde committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d24f4d9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Improvements suggested by Josh McKinney. 

    - Added comment with rational for window size fallback mechanism.
- Only unwrap once during parsing of env vars.
    @swilde
    swilde committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4a61d41 View commit details
    Browse the repository at this point in the history