binutils,gdb: fix enabling zstd compression

[sobczyk]

No description provided.

[sobczyk]

It was always disabled due to additional curly brace, thus bash expanded the variable badly.
It's broken in 1.26.0, It'd be nice to have 1.26.1

[cpackham]

Hmm, macos seems unhappy with this

[ALL  ]    /Users/runner/work/crosstool-ng/crosstool-ng/x-tools/arm-unknown-linux-musleabi/lib/gcc/arm-unknown-linux-musleabi/13.2.0/../../../../arm-unknown-linux-musleabi/bin/ld.bfd: linux-tdep.o: in function `linux_corefile_thread(thread_info*, gdbarch*, bfd*, std::unique_ptr<char, gdb::xfree_deleter<char> >&, int*, gdb_signal)':
[ALL  ]    linux-tdep.c:(.text+0x4d0c): undefined reference to `gcore_elf_build_thread_register_notes(gdbarch*, thread_info*, gdb_signal, bfd*, std::unique_ptr<char, gdb::xfree_deleter<char> >*, int*)'
[ALL  ]    /Users/runner/work/crosstool-ng/crosstool-ng/x-tools/arm-unknown-linux-musleabi/lib/gcc/arm-unknown-linux-musleabi/13.2.0/../../../../arm-unknown-linux-musleabi/bin/ld.bfd: linux-tdep.o: in function `linux_make_corefile_notes(gdbarch*, bfd*, int*)':
[ALL  ]    linux-tdep.c:(.text+0x586c): undefined reference to `gcore_elf_make_tdesc_note(gdbarch*, bfd*, std::unique_ptr<char, gdb::xfree_deleter<char> >*, int*)'
[ALL  ]    /Users/runner/work/crosstool-ng/crosstool-ng/x-tools/arm-unknown-linux-musleabi/lib/gcc/arm-unknown-linux-musleabi/13.2.0/../../../../arm-unknown-linux-musleabi/bin/ld.bfd: /Users/runner/work/crosstool-ng/crosstool-ng/.build/arm-unknown-linux-musleabi/build/build-gdb-native/bfd/.libs/libbfd.a(compress.o): in function `decompress_contents':
[ALL  ]    compress.c:(.text+0x107c): undefined reference to `ZSTD_decompress'
[ALL  ]    /Users/runner/work/crosstool-ng/crosstool-ng/x-tools/arm-unknown-linux-musleabi/lib/gcc/arm-unknown-linux-musleabi/13.2.0/../../../../arm-unknown-linux-musleabi/bin/ld.bfd: compress.c:(.text+0x1088): undefined reference to `ZSTD_isError'
[ALL  ]    /Users/runner/work/crosstool-ng/crosstool-ng/x-tools/arm-unknown-linux-musleabi/lib/gcc/arm-unknown-linux-musleabi/13.2.0/../../../../arm-unknown-linux-musleabi/bin/ld.bfd: /Users/runner/work/crosstool-ng/crosstool-ng/.build/arm-unknown-linux-musleabi/build/build-gdb-native/bfd/.libs/libbfd.a(compress.o): in function `bfd_compress_section_contents':
[ALL  ]    compress.c:(.text+0x14fc): undefined reference to `ZSTD_compress'
[ALL  ]    /Users/runner/work/crosstool-ng/crosstool-ng/x-tools/arm-unknown-linux-musleabi/lib/gcc/arm-unknown-linux-musleabi/13.2.0/../../../../arm-unknown-linux-musleabi/bin/ld.bfd: compress.c:(.text+0x1510): undefined reference to `ZSTD_isError

[sobczyk]

I just realized that ${complibs} is empty and will not enable zstd compression.
The fix should not be too difficult

[sobczyk]

The last fail does not look like a macos failure.
I'm doing some checks on my ctng built toolchain and --compress-debug-sections=zstd failed in objdump.
I'll recheck the fixes

[cpackham]

Yeah the free tier macos runners aren't the most reliable. Looks like you've identified other issues but we can always give the build another run if it fails because of the runners.

…

On Thu, 25 Apr 2024, 6:13 am Szymon Sobik, ***@***.***> wrote: The last fail does not look like a macos failure — Reply to this email directly, view it on GitHub <#2144 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGAE5A6MV4KVX5XKJFCNLY67Y4JAVCNFSM6AAAAABGPINX56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGU2DSNZYGQ> . You are receiving this because you commented.Message ID: ***@***.***>