gettext: Fix cross build for mingw #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick the following commit from gnulib: ctime, localtime, tzset, wcsftime: Fix env access (regr. 2024-02-09). https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=92cdf62b56462b914193c7770440e505a37c2526 This upstream patch fixes the following error: [ERROR] .../.build/HOST-x86_64-w64-mingw32/pru-elf/src/gettext/gettext-tools/gnulib-lib/localtime.c:66:24: error: initialization of 'char *' from incompatible pointer type 'char **' [-Wincompatible-pointer-types] [ALL ] 66 | for (char *s = env; *s != NULL; s++) Crosstool configuration: build: x86_64-unknown-linux-gnu host: x86_64-w64-mingw32 target: pru-elf Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
cpackham
force-pushed
the
mingw-20240527-fix-gnulib
branch
from
e606a3c
to
0857408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit from gnulib:
ctime, localtime, tzset, wcsftime: Fix env access (regr. 2024-02-09).
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=92cdf62b56462b914193c7770440e505a37c2526
This upstream patch fixes the following error:
[ERROR] .../.build/HOST-x86_64-w64-mingw32/pru-elf/src/gettext/gettext-tools/gnulib-lib/localtime.c:66:24: error: initialization of 'char *' from incompatible pointer type 'char **' [-Wincompatible-pointer-types]
[ALL ] 66 | for (char *s = env; *s != NULL; s++)
Crosstool configuration:
build: x86_64-unknown-linux-gnu
host: x86_64-w64-mingw32
target: pru-elf