Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: update packaging #352

Merged
merged 1 commit into from Jun 6, 2017

Conversation

cpackham
Copy link
Contributor

Support building in tree and from a released tarball by optionally
running ./bootstrap.

Fix some issues reported by lintian.
-E: crosstool-ng changes: bad-distribution-in-changes-file unstable
-E: crosstool-ng source: build-depends-on-essential-package-without-using-version build-depends: gzip
-E: crosstool-ng source: build-depends-on-essential-package-without-using-version build-depends: tar
-W: crosstool-ng source: syntax-error-in-dep5-copyright line 14: Cannot parse line "Unless otherwise stated in individual files, this work is licensed to you under"
-E: crosstool-ng: copyright-should-refer-to-common-license-file-for-lgpl
-E: crosstool-ng: description-starts-with-package-name
-E: crosstool-ng: section-is-dh_make-template
-E: crosstool-ng: depends-on-obsolete-package depends: texi2html

Signed-off-by: Chris Packham chris.packham@alliedtelesis.co.nz

@cpackham
Copy link
Contributor Author

This is the start of my effort to try and get this into debian (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695545)

This first change just cleans up some style errors and makes it so that it should be possible to create from the repository and from a released tarball.

@nekromant FYI

@cpackham
Copy link
Contributor Author

I've restored git, subversion and bzip2 in this update. I've left off gzip since it's in build-essentials. I've also switched back to libtool-bin.

@bhundven
Copy link
Contributor

Do you have any updates for this?

@cpackham
Copy link
Contributor Author

Hi Bryan,

I wasn't getting much luck on the debian lists[1]. I really need a debian developer to sponsor this and to provide feedback. Anyone know one?

[1] - https://lists.debian.org/debian-wnpp/2016/02/msg00895.html

@bhundven
Copy link
Contributor

I'll set this to waiting for response until that happens then.

@stilor stilor modified the milestones: 1.23.0, 1.24.0 Mar 6, 2017
@bhundven
Copy link
Contributor

@cpackham Any updates?

@cpackham
Copy link
Contributor Author

Hi Bryan,

Sorry no nothing. I'll at least update this based on the 1.23 release. Probably won't have any time to spend on it for a while.

Support building in tree and from a released tarball by optionally
running ./bootstrap.

Fix some issues reported by lintian.
-E: crosstool-ng changes: bad-distribution-in-changes-file unstable
-E: crosstool-ng source: build-depends-on-essential-package-without-using-version build-depends: gzip
-E: crosstool-ng source: build-depends-on-essential-package-without-using-version build-depends: tar
-W: crosstool-ng source: syntax-error-in-dep5-copyright line 14: Cannot parse line "Unless otherwise stated in individual files, this work is licensed to you under"
-E: crosstool-ng: copyright-should-refer-to-common-license-file-for-lgpl
-E: crosstool-ng: description-starts-with-package-name
-E: crosstool-ng: section-is-dh_make-template
-E: crosstool-ng: depends-on-obsolete-package depends: texi2html

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
@cpackham
Copy link
Contributor Author

cpackham commented Jun 5, 2017

@bhundven, @stilor I've finally had contact from a debian developer. This PR has been updated with changes suggested. Still working on actually getting things in.

@stilor
Copy link
Contributor

stilor commented Jun 6, 2017

Can you tell me how to test this debian framework so that I can check it still works at the time of the next release?

@cpackham
Copy link
Contributor Author

cpackham commented Jun 6, 2017

testing shouldn't be too hard something along the lines of

debuild -i -us -uc -b
sudo dpkg -i crosstool-ng-blah.deb

Then maybe build one of the example defconfigs

@stilor
Copy link
Contributor

stilor commented Jun 6, 2017

Ok, I'll merge and try it out.

@stilor stilor merged commit 10089f3 into crosstool-ng:master Jun 6, 2017
@stilor
Copy link
Contributor

stilor commented Jun 7, 2017

A few notes:

  1. Running debuild -i -us -uc -b on a freshly installed Debian Jessie did not produce a package. Rather the following issues were reported by lintian:
W: crosstool-ng: hardening-no-relro usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/kconfig/conf
W: crosstool-ng: hardening-no-relro usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/kconfig/mconf
W: crosstool-ng: hardening-no-relro usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/kconfig/nconf
W: crosstool-ng: package-contains-vcs-control-file usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/config/.gitignore
W: crosstool-ng: package-contains-vcs-control-file usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/scripts/.gitignore
W: crosstool-ng: manpage-has-errors-from-man usr/share/man/man1/ct-ng.1.gz 1: warning: macro `"' not defined
W: crosstool-ng: script-not-executable usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.12.1/170-localedef-fix-trampoline.patch
E: crosstool-ng: shell-script-fails-syntax-check usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.12.1/170-localedef-fix-trampoline.patch
W: crosstool-ng: script-not-executable usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.13/170-localedef-fix-trampoline.patch
E: crosstool-ng: shell-script-fails-syntax-check usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.13/170-localedef-fix-trampoline.patch
W: crosstool-ng: script-not-executable usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.14.1/170-localedef-fix-trampoline.patch
E: crosstool-ng: shell-script-fails-syntax-check usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.14.1/170-localedef-fix-trampoline.patch
W: crosstool-ng: script-not-executable usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.14/170-localedef-fix-trampoline.patch
E: crosstool-ng: shell-script-fails-syntax-check usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.14/170-localedef-fix-trampoline.patch
W: crosstool-ng: script-not-executable usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.15/170-localedef-fix-trampoline.patch
E: crosstool-ng: shell-script-fails-syntax-check usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.15/170-localedef-fix-trampoline.patch
W: crosstool-ng: script-not-executable usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.16.0/170-localedef-fix-trampoline.patch
E: crosstool-ng: shell-script-fails-syntax-check usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/patches/glibc/ports-2.16.0/170-localedef-fix-trampoline.patch
W: crosstool-ng: executable-not-elf-or-script usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/scripts/crosstool-NG.sh
W: crosstool-ng: executable-not-elf-or-script usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/scripts/build/companion_libs/210-expat.sh
W: crosstool-ng: executable-not-elf-or-script etc/bash_completion.d/ct-ng.comp
W: crosstool-ng: executable-not-elf-or-script usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/kconfig/kconfig.mk
W: crosstool-ng: executable-not-elf-or-script usr/lib/x86_64-linux-gnu/crosstool-ng-1.22.0-816-g10089f3-dirty/scripts/scripts.mk
  1. I noticed that running debuild replaces config.sub/config.gues with older files. Crosstool-NG has more recent versions of them. You might want to remove --with autotools-dev from dh command line (and perhaps, drop autotools-dev from the dependencies).

  2. Similarly, I had only libncurses5 (and its -dev) installed and the kconfig binaries built fine. debuild wants wide-char version of ncurses installed too (libncursesw5 and libncursesw5-dev); I am not sure it is really a dependency.

  3. Is it possible to produce a .deb for Ubuntu? Running the same command on Ubuntu results in

E: crosstool-ng changes: bad-distribution-in-changes-file unstable

because Ubuntu does not have unstable. But it is apparently sharing the files, including the changelog. Can the same set of files in debian/ be reused for both Debian and Ubuntu? I am not familiar with .deb creation, so I'd appreciate some guidance here.

@stilor
Copy link
Contributor

stilor commented Jun 7, 2017

A correction to the above: removing --with autotools-dev does not prevent overriding config.sub/config.guess with older versions. I don't know how to tell dh to leave them alone, but overriding them with older versions seems wrong.

@cpackham
Copy link
Contributor Author

cpackham commented Jun 7, 2017 via email

@stilor
Copy link
Contributor

stilor commented Jun 7, 2017

config.sub/config.guess don't appear to be part of the git repo. Where you building in a clean worktree? There are probably options to tell deb-helper to avoid re-running certain steps.

Yes they are, in scripts/ directory. Yes, I was building in a clean check out from git - just run 'git diff' after the debuild -i -us -uc -b and it will show the scripts/config.* have been replaced.

@stilor
Copy link
Contributor

stilor commented Jun 7, 2017

Have a look at #738 - this fixes the remaining warnings/errors from lintian on my installation.

The question about Ubuntu flavor of deb package remains, though:

E: crosstool-ng changes: bad-distribution-in-changes-file unstable

@cpackham cpackham deleted the debian-packaging-update branch August 2, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants