Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making libmpx configurable & moving gcc libs: more fixes #461

Merged
merged 3 commits into from Nov 8, 2016
Merged

Making libmpx configurable & moving gcc libs: more fixes #461

merged 3 commits into from Nov 8, 2016

Conversation

stilor
Copy link
Contributor

@stilor stilor commented Oct 5, 2016 •
edited

Recent changes broke x86--mingw32, x86--musl and m68k-*-uclibc samples.

@stilor
Fine-tune moving gcc libraries to sysroot.
3330ad7 
1. Check if anything was installed outside sysroot; on some [baremetal only?]
configurations GCC doesn't install anything to ${CT_PREFIX_DIR}/${CT_TARGET}/lib.
2. We need to create <sysroot>/lib/<multilib> if it doesn't exist
(MUSL only installs in <sysroot>/usr/lib).
3. Do not move the linker scripts; elf2flt expects to find them
in gcc's dir, not sysroot.

Signed-off-by: Alexey Neyman <stilor@att.net>
@stilor
MINGW doesn't like libmpx either.
339b83c 
Signed-off-by: Alexey Neyman <stilor@att.net>
@KirillSmirnov
Copy link
Contributor

multilib mingw still failing:

libsupc++.a'
[DEBUG] ==> Executing: 'mv' '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/lib/../lib/libvtv.a' '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/sysroot/lib/../lib/libvtv.a'
[DEBUG] ==> Executing: 'mv' '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/lib/../lib/libvtv_stubs.a' '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/sysroot/lib/../lib/libvtv_stubs.a'
[DEBUG] Entering 'movelibs_32'
[DEBUG] ==> Executing: 'mv' '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/lib/../lib32/libatomic.a' '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/sysroot/lib/../lib32/libatomic.a'
[ALL ] mv: cannot move '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/lib/../lib32/libatomic.a' to '/home/lich/x-tools/x86_64-w64-mingw32/x86_64-w64-mingw32/sysroot/lib/../lib32/libatomic.a': No such file or directory

build.log.zip
config.zip

@KirillSmirnov
Copy link
Contributor

False negative, wrong branch again :-(
mingw is OK.

@stilor
Copy link
Contributor Author

stilor commented Oct 10, 2016

@bhundven Ok to merge? Most baremetal & mingw samples currently fail because of these issues.

@stilor
Copy link
Contributor Author

stilor commented Oct 12, 2016

Ping?

@bhundven
Copy link
Contributor

The branch is out of date. This seems to happen every time I do a pull request.
There is a button there that You can press to "Update branch". If I had write access to your branch, I could press the "Update branch" button and merge it.

screen shot 2016-10-12 at 11 54 54 am

bhundven
bhundven approved these changes Oct 12, 2016
View reviewed changes
Copy link
Contributor

@bhundven bhundven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@stilor
Copy link
Contributor Author

stilor commented Oct 12, 2016

Updated, but now Travis is off building it again.

@bhundven
Copy link
Contributor

It's fine. I still need to workout PR workflow issues like this.

@stilor
Copy link
Contributor Author

stilor commented Oct 12, 2016

On an unrelated note (don't know if you're currently on IRC):
I rolled out a mini-travis of my own :) a build script that pulls new commits and rebuild all samples, but limits its runtime to the period when I am not using my workstation
it currently doesn't handle canadian crosses
but I probably can improve it in that aspect
I guess we could have a contrib/ directory in crosstool-ng so that others can start build-testing crosstool-ng in their environments without loading their machine during the times when it is used
also, regarding other things I want in ct-ng: I want to build companion tools for host as well, so that the produced toolchain comes with a defined version of make/m4/whatnot if one wants it
what do you think?

@stilor
Copy link
Contributor Author

stilor commented Oct 12, 2016

Travis failed during download state. Can the builds for failed samples be restarted?

@bhundven
Copy link
Contributor

Cleared the caches, restarted the build.

@stilor
Copy link
Contributor Author

stilor commented Oct 12, 2016

Same again on a different set of samples... Travis seems to be unstable.

@bhundven
Copy link
Contributor

Come to find out that travis-ci's default build image is ubuntu precise 12.04.
The ssl keys are now out of date enough that kernel.org has already updated their key and now it doesn't match.

Luckily, they have a beta for trusty 14.04. I have #466 open to resolve that issue.

@stilor stilor merged commit 23e9a03 into crosstool-ng:master Nov 8, 2016
@stilor stilor deleted the static-libgcc-more-fixes branch November 10, 2016 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhundven bhundven bhundven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stilor @KirillSmirnov @bhundven