Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin fixes #494

Merged
merged 5 commits into from
Dec 6, 2016
Merged

Cygwin fixes #494

merged 5 commits into from
Dec 6, 2016

Conversation

stilor
Copy link
Contributor

@stilor stilor commented Dec 5, 2016

Various issues on Cygwin. This started as an attempt to verify issue 455 and other cygwin issues quickly followed.

This should be fixing issue 380, issue 407, issue 455 and issue 458 + an (unreported in issues) problem while installing kernel headers on Cygwin.

@stilor
Copy link
Contributor Author

stilor commented Dec 5, 2016

We should update gettext to 0.19.8.1, btw. It looks like the 140/150-*.patch is picked up upstream, but I want to first establish a cygwin baseline as well.

With these changes, x86_64-w64-mingw32 and x86_64-w64-mingw32,x86_64-pc-linux-gnu samples build ok.

Copy link
Contributor

@bhundven bhundven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the one typo, and we'll get this merged.

@@ -1655,7 +1656,12 @@ CT_IterateMultilibs() {
multi_os_dir=.
fi

CT_mkdir_pushd "${prefix}_${multi_dir//\//_}"
# Brain-dead Cygwin hack: Cygwin cannot run a binary if there is a directory
# componen in the path that ends with a dot. Unfortunately, that's the case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/componen/component/

@stilor stilor force-pushed the cygwin-fixes branch 2 times, most recently from aabcb4c to 9a0afb8 Compare December 6, 2016 02:39
@stilor
Copy link
Contributor Author

stilor commented Dec 6, 2016

Done.

Signed-off-by: Alexey Neyman <stilor@att.net>
120-*.patch needed an update; others copied verbatim.

Signed-off-by: Alexey Neyman <stilor@att.net>
From gnulib´s mailing list; paths modified to match gnulib module inside
gettext.

Signed-off-by: Alexey Neyman <stilor@att.net>
3.0.9/100-headers-install-fix*.patch picked up upstream.
The Cygwin fix is needed for Cygwin on all kernel versions.

Signed-off-by: Alexey Neyman <stilor@att.net>
Cygwin doesn't like directory names ending with a dot, e.g. "multilib_."

Signed-off-by: Alexey Neyman <stilor@att.net>
Copy link
Contributor

@bhundven bhundven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stilor stilor merged commit da3f8c4 into crosstool-ng:master Dec 6, 2016
@stilor stilor deleted the cygwin-fixes branch December 7, 2016 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants