Properly handle newlib configuration flags #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Useful, thanks! But i'm not sure that this is true for all supported versions of newlib. Do you use newlib 2.5.0.20171222 or 3.0.0.20180226 ? |
|
I'm currently using newlib 3.0.0.20180226; however, git shows no changes in newlib's configure.in from 2.5.0.20171222, so I think it is safe to assume that the configuration flags did not change between these two versions. |
|
A good fix. Just notice that I've looked at full history of newlib/configure.in . I found all old versions of newlib had a |
|
Any news on if/when this pull request will be merged? Should I improve it in any way to make it mergeable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some configuration-time flags for newlib are prefixed with "newlib-", i.e. we need to pass --enable-newlib-FEATURE to the configure script. Unfortunately, newlib.sh do not add this prefix when enabling the features atexit-dynamic-alloc, reent-small, multithread, and unbuf-stream-opt. Thus, enabling these options in crosstool-ng's config has no effect on the generated libc.
This patch fixes this bug.