perfStart and perfStop breaking code in the browser

[taylorhadden]

The usage of process.env.LOG_PERF on lines 214 and 218 of utilities.ts is causing an exception when translate() is called within the browser.

I have had luck using the following patten to make code work across node and browser contexts:

if (typeof global === 'undefined') {
    // Browser code
}
else {
    // Node code
}

I can create a PR to add this. Is this desirable?

[hrishikesh-k]

I'm having the same issue. At first I thought this is not compatible with browsers (because even the name sid node), but checked readme and it says it's supported in browsers.

I'd personally think, having console.time() is not required in browser builds. It should be only used for testing and benchmarking purposes.

Unfortunately, this was the only library perfece for my needs as it allowed easy customization for the Markdown output. Sadly, it seems this PR will take time. :(

[SettingDust]

Should removed by https://github.com/crosstype/node-html-markdown/blob/master/transformer.js. Maybe not working

Edit: Only removed the invoke

[SettingDust]

For now can use "node-html-markdown": "https://github.com/SettingDust/node-html-markdown"

[nonara]

Very sorry for the delay on this! My backlog was overloaded and I didn't catch this. Thanks @SettingDust for the PR.

Merged

[thomasefbland]

This error is still in the code and still persists

[josiah-roberts]

+1, still broken.