Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from ActionMailer #1

Closed
Eonasdan opened this issue Aug 19, 2014 · 2 comments
Closed

Changes from ActionMailer #1

Eonasdan opened this issue Aug 19, 2014 · 2 comments

Comments

@Eonasdan
Copy link

I started using your nuget/repo since the original is no longer updated. You've made some breaking changes that I'd like to suggest that "put back"

  • If you could, please make SetMailMethod(...); optional. I don't want to have to specify this in each action. I'd like to either have a place in the controller that overrides this or let it default to SMTP.
  • I now have to add MailAttributes in front of To, From, etc. which addes to my setup time if I copy mail actions/view across applications

SetMailMethod is more annoying then the second point.

Thank you keeping this project maintained.

@AndrewHK
Copy link
Contributor

Your first point is kind of already implemented as suggested (if SetMailMethod is not called, It will use SMTP by default in MailerBase.)

MailAttributes = mailAttributes ?? MailMethodUtil.GetAttributes();
MailSender = mailSender ?? MailMethodUtil.GetSender();

You have a fair point with the MainAttributes thing, We'll look into it soon.

Thanks for your feedback.

@Eonasdan
Copy link
Author

ah ok. I had to look at the wiki for the usage instructions since it was different. Maybe the wiki should be modified to include a comment as such.

I also realized that the To and From want a MailAddress instead of a string so I'm going to have to change any migrated function over anyway. So, adding MailAttributesisn't going to be to much extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants