This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
setAcceptFileSchemeCookies Support cookies on file:// option #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one would definitely save my life! |
|
Please combine those commits into ones. |
fujunwei
reviewed
Dec 17, 2016
| @@ -72,9 +74,12 @@ Licensed to the Apache Software Foundation (ASF) under one | |||
| protected XWalkActivityDelegate activityDelegate; | |||
| protected String startUrl; | |||
| protected CordovaPreferences preferences; | |||
| protected boolean xwalkFileSchemeCookies; | |||
fujunwei
reviewed
Dec 17, 2016
| @@ -87,6 +92,11 @@ public void run() { | |||
| public void run() { | |||
| cookieManager = new XWalkCordovaCookieManager(); | |||
|
|
|||
| if (xwalkFileSchemeCookies) { | |||
There was a problem hiding this comment.
Move to initWebViewSettings() function
|
Hi, is this fix working for you when system's webview is not updated? I've patched my crosswalk and only works when system's webview is updated (even though user agent is still the same: Any ideas on what's happening? I thought crosswalk would embed a chromium version into the webview loaded by cordova. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium disable cookies on file:// so we have to use localStorage in Ionic application
However, some third party may require cookies.
XWALK_FILE_SCHEME_COOKIES preference setting enable cookie
(default / false)