Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Path to the libs are changing between different versions of xwalk #1

Closed
townxelliot opened this issue Feb 5, 2014 · 6 comments
Closed

Comments

@townxelliot
Copy link
Contributor

Issue by DonnaWuDongxia from Tuesday Jan 07, 2014 at 11:09 GMT


Path to the libs are changing between different versions of xwalk, for example:

crosswalk-2.31.27.5-x86/xwalk_app_template/native_libs/libs/x86/libxwalkcore.so
crosswalk-4.32.64.0-x86/xwalk_app_template/native_libs/x86/libs/x86/libxwalkcore.so

crosswalk-4.32.64.0-x86/xwalk_app_template/libs/xwalk_app_runtime_java.jar
crosswalk-2.31.27.5-x86/xwalk_app_template/libs/xwalk_app_runtime_client_java.jar

But xwalk-apk-generator tries to find these libs in some hard-coded path. Then errors are throw when we use unmatched xwalk.

@townxelliot
Copy link
Contributor Author

Comment by townxelliot from Tuesday Jan 07, 2014 at 11:26 GMT


Yes, this is an issue. The current version will only work with very recent xwalk android versions. I don't do any directory walking to find the library files (though it would be possible to change that: I do fall back to walking directories when looking for the Android SDK tools, for example).

I have reasons for not directory walking (e.g. if multiple .so files were in the app template, you would only want the one in the x86 directory, so you need to discriminate at least a little bit). But I raised another issue to suggest solutions so I can support multiple versions of xwalk-android: see #8.

The issue for the native libraries is that the Ant task needs to be passed the directory two levels up from the .so file, and I haven't done anything sophisticated enough to cope with that. Instead I look for a specific directory.

For the jar files, I could probably just search for multiple filenames and include any that match.

@townxelliot
Copy link
Contributor Author

Comment by townxelliot from Tuesday Jan 28, 2014 at 13:59 GMT


I've now added a comment that xwalk-apk-generator supports Crosswalk-4.

In future, if there's call for it, I will resolve #8 to provide support for multiple versions of Crosswalk.

If you have no objection, I will close this issue and consider it covered by #8.

@saket424
Copy link

I am unable to get shared mode to work in crosswalk-5. Embedded mode works fine. Even after I install the related ./crosswalk-5.32.90.0-arm/apks/XWalkRuntimeLib.apk file on the device, the shared mode apk which is much smaller in size compared to embedded mode apk, fails to detect that the shared mode library is avaliable on the device. Is Crosswalk-5 supported and is there some specific issue with Shared mode?

@townxelliot
Copy link
Contributor Author

I've just tried creating a shared mode apk using this project, rather than the make_apk.py script (I'm not sure which you're using), with the same crosswalk version (5.32.90.0-arm). Shared mode works for me. If you are using this generator (rather than make_apk.py) and it's producing a non-working apk, please file a separate bug with more details and we'll try to help.

@saket424
Copy link

I am using this generator I think. I have opened Issue29 with more information. Thanks

@townxelliot
Copy link
Contributor Author

The apk generator does support versions 4 and 5 of Crosswalk now. I'm closing this as there's no movement on the bug any more.

It should be possible to add additional search paths for libraries if they move directory or change name in future, as the code can support multiple search paths and will fall back to globbing if it can't find a particular file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants