Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
update #877 back up required gtk to 3.18 because navbar gets lost.
- Loading branch information
1 parent
a03fc0b
commit 4d6c2ad
4d6c2adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.18 is not the lowest version, maybe 3.0?
4d6c2adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wondered how far back to go. when i first released X4.1.0, tim dickson wrote to say he was missing the navbar. after some extensive fiddling, he discovered that version stamps like that were in the way, either that or the src/gui/utilities.h #ifdef for which UI_SUFFIX to use. the weirdness is that the navbar simply disappears, and gtk generates no error to whine about it.
i could change this to 3.0, but as a practical matter, is 3.18 or maybe 3.14 the actual earliest to be found in the wild? and might it cause any actual harm to use 3.0 instead of 3.18?
4d6c2adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 14.04 LTS, which still has a year of life left on it, has GTK 3.10. Generally that's the oldest we care about. (CentOS/RHEL 6 completely lacks gtk3 from what I can tell and 7 only has it in the EPEL repository so it's pretty up to date at 3.22)