-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build, "error: template with C linkage" #1083
Comments
i'm really not sure what to tell you. fedora has had sword 1.9 since christmas eve, and the obligatory xiphos rebuild appeared the same day. all is good here. |
Xiphos hasn't been building the entirety of the Fedora 34 rawhide/beta cycle. Same error. Something has changed in the toolchain and I haven't the slightest idea what it is. |
Some fresh |
gcc or glibc. I'm not sure which it would be |
most probably gcc-10
|
I was wrong. That's glib2.
The root issue is that GLIB_VERSION_MIN_REQUIRED is not defined.
See the commit message here: https://gitlab.gnome.org/GNOME/glib/-/commit/4273c43902a7e6b22cea0041436ee5715c93be76 and some discussion here: https://gitlab.gnome.org/GNOME/glib/-/issues/2331
|
just checked that putting
#define GLIB_VERSION_MIN_REQUIRED (GLIB_VERSION_2_26)
into `cmake/config.h.cmake.in` fixes the problem (as a workaround).
|
Thanks for the info. I left a machine compiling |
Wow thanks for tracking that down. I can confirm the suggestion works to get Xiphos compiling again on Arch Linux. For now I've add this patch to the packaging just to get things running again, but clearly the right thing to do is figure out what the proper fix is and apply it here upstream. |
it wouldn't have been the compiler itself in any event, as f33 has had 10 all along:
thanx to @ildar for the discovery. |
Recently came across this suggestion due to upcoming changes in Fedora Rawhide (dealing with autotools). But, they suggest, it's no longer necessary to do |
But that's only for newer GLib versions. If we want to keep Xiphos building
with older versions then have to keep extern "C". Am i getting it right?
|
How new of GLib, though? Our real issue is we want to stay on a downright archaic version of GTK+. I don't think we have a specific need to stay on older GLib except where it is necessary for our older GTK+ dependency. I don't know when GLib began to support C++, but I do know it is currently incorrect to include GLib headers in an |
Hmm, that's interesting. Never seen that in the whole discussion at GNOME
site.
Fairly I'm not a big fan of all that cpp's kitchen staff.
Would you make a (PoC) patch so we'd see how it works without or outside
the externC constructs? Thanks.
|
if we apply @alerque 's patch above -- a 1-line addition to cmake/config.h.cmake.in -- is that sufficient to get us back into business in F34? i'm still on F33 and can't afford to make the jump forward yet. |
Yes, his patch fixes us up on Fedora. We are live in F34 and Rawhide again with that change. We do need to spread the patch to others as well. I just got a notice that SUSE builds have also started failing. Presumably for the same reason. Presumably other distros will as well as they update. Glib maintainers have rejected fixing this in their code base, instead preferring to tell applications it is their responsibility to properly not call their headers with extern. So we should adopt some form of final fix into Xiphos based on detected Glib versions. |
does this mean that a working build is in testing now? |
Obtained from [1] via [2]. [1] https://aur.archlinux.org/cgit/aur.git/tree/xiphos-glibc.patch?h=xiphos [2] crosswire/xiphos#1083 PR: 256200
I have also a build problem with Ubuntu:
|
@LAfricain , you have a completely different error. The builder cannot find
`webkit`.
Please ask for help at #xiphos on libera.chat
|
Arch Linux recently updated the SWORD library in the official repos. This makes the unofficial SVN one I've been hosting to provide Xiphos builds obsolete and the current builds are dead.
In trying to update and for some reason I can't rebuild Xiphos at all. I've tried with both the official SWORD 1.9.0 package and and updated SVN release and got nowhere.
The errors start here and go on ad nauseam:
The text was updated successfully, but these errors were encountered: