Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape key doesn't properly close the Options dialog #1154

Closed
nwalkewicz opened this issue Jun 15, 2024 · 1 comment · Fixed by #1168
Closed

Escape key doesn't properly close the Options dialog #1154

nwalkewicz opened this issue Jun 15, 2024 · 1 comment · Fixed by #1168

Comments

@nwalkewicz
Copy link
Contributor

Pressing Esc while in the Options dialog closes it in the UI, but prevents the dialog from being opened again until Xiphos is reopened. When Xiphos is reopened after this point, the dialog is automatically opened again, as if it was only hidden initially instead of being fully closed.
@Phyrik Phyrik mentioned this issue Aug 11, 2024
Merged
@Phyrik
Copy link
Contributor

Phyrik commented Aug 11, 2024

I've proposed a fix in #1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

properly close preferences dialog on escape key Phyrik/xiphos
2 participants
@nwalkewicz @Phyrik