New API for loading Station XML #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 27, 2016 15:52
…kes in a java.io.Reader instance instead of a filename. This method adds flexibility to the API so that users can pull data from non-file sources.
Also included is a change the the filename version of the loadStationXML method that call the new InputStream-based version to avoid code duplication.
|
Looks good, thanks for submitting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dr. Crotwell,
This pull request contains three commits.
The first two commits add loadStationXML methods that take in an InputStream and a Reader instance, and refactors the filename method to use the new InputStream version to avoid code duplication. The motivation for these changes was to be able to use your library with StationXML data not necessarily stored in a file but as a blob somewhere else (Hadoop HDFS, Oracle, etc.).
The third commit contains source formatting done by by IDE, as well as code changes to eliminate compiler warnings.
Thanks,
Steven Magana-Zook
Lawrence Livermore National Laboratory