Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode? #487

Open
perguto opened this issue Nov 13, 2022 · 18 comments
Open

Dark Mode? #487

perguto opened this issue Nov 13, 2022 · 18 comments
Labels
enhancement New feature or request

Comments

@perguto
Copy link

perguto commented Nov 13, 2022

Is there a dark mode for the Windows GUI? I didn't find one in the settings. It would be nice to have one. Thanks for this awesome program btw!

@perguto perguto added the enhancement New feature or request label Nov 13, 2022
@VolkMilit
Copy link
Contributor

It depends on your system settings. Windows 10 has an option to turn dark mode.

@Shatur
Copy link
Member

Shatur commented Feb 23, 2023

Icon support is needed. We need to bundle both variants and select automatically the correct one based on system settings.

@VolkMilit
Copy link
Contributor

VolkMilit commented Mar 2, 2023

Qt 5 doesn't have an native API for dark\lite theme, or I'm not aware where to look. On windows we can use registry to determine user settings in HKEY_CURRENT_USER\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize

@vvkdev
Copy link

vvkdev commented Mar 27, 2023

How to activate the dark mode? My Windows 10 dark mode is on and other apps are dark, but Crow not.

@VolkMilit
Copy link
Contributor

@vvkdev AFAIK, you can't, not with Qt 5 anyway. Qt 6 support this natively, but some Linux distribution still ship old Qt 5, that's why we wait for them.

@1821746019
Copy link

it seems that crowTranslate still cannot support dark mode. White of the gui is really dazzling.

@AlbertoFabbri93
Copy link

I installed the flatpak version of Crow Translate on my Linux system (OpenSuse Aeon with Gnome) and when I enable dark mode this is how it looks:

Screenshot from 2023-07-31 00-40-39

It is impossible to see the icons of the buttons.

@MesterPerfect
Copy link

Before, I used obs-studio on Windows 32-bit, which means it was utilizing Qt5. The program's default theme was dark. Therefore, I believe achieving a dark theme is possible with either Qt5 or Qt6.

@Shatur
Copy link
Member

Shatur commented Dec 21, 2023

OBS uses custom styles, it's not a default dark Qt theme.

@Gentleman03
Copy link

OBS uses custom styles, it's not a default dark Qt theme.

Then maybe you would be able to add some way to use custom styles?

@Shatur
Copy link
Member

Shatur commented Apr 16, 2024

I personally dislike custom styles. It's better to just migrate to Qt6.

@MesterPerfect
Copy link

I personally dislike custom styles. It's better to just migrate to Qt6.

I also prefer transitioning to QT6 as it offers better support for light and dark styles, as well as enhanced accessibility features. Additionally, it will eliminate the need for x86 support.

@Shatur
Copy link
Member

Shatur commented Apr 16, 2024

I wish I could have more free time...
I currently quite busy with another project, so a PR would be highly appreciated. I will be able to review it quickly, just don't have enough time to sit and do the migration myself.

@MesterPerfect
Copy link

I wish I could have more free time... I currently quite busy with another project, so a PR would be highly appreciated. I will be able to review it quickly, just don't have enough time to sit and do the migration myself.

I was hoping I could assist you, but I primarily develop using Python and have no experience with C++.

@Shatur
Copy link
Member

Shatur commented Apr 16, 2024

It's okay, maybe some else will.

@Gentleman03
Copy link

I personally dislike custom styles. It's better to just migrate to Qt6.

Ofcourse, especially if adding a custom styles feature isn't a quick thing to add.

It's okay, maybe some else will.

I'm afraid it's not going to happen. Latest feature request for dark theme is 2 years old.

@Shatur
Copy link
Member

Shatur commented Apr 16, 2024

Latest feature request for dark theme is 2 years old.

True, but Qt6 wasn't ready for quite some time too. For example, QtMultimedia was re-introduced only in 6.2.

@Aqa-Ib
Copy link

Aqa-Ib commented May 16, 2024

I'm afraid it's not going to happen. Latest feature request for dark theme is 2 years old.

This program is very useful. There are odds of someone with the knowledge to port it to Qt6. I think that a pinned issue asking for help would improve the chances. Regards.

@Shatur Shatur mentioned this issue Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

9 participants