Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Non-common icon res files #685

Closed
tim77 opened this issue May 24, 2024 · 4 comments · Fixed by #689
Closed

Non-common icon res files #685

tim77 opened this issue May 24, 2024 · 4 comments · Fixed by #689
Labels
bug Something isn't working

Comments

@tim77
Copy link
Contributor

tim77 commented May 24, 2024

Bug description
Some Linux linters unhappy about few icon res which considered non-canonical for Linux desktops according to freedesktop specification:

  • /usr/share/icons/hicolor/44x44/
  • /usr/share/icons/hicolor/150x150/
  • /usr/share/icons/hicolor/310x310/

Basically this icon formats unused in Linux desktops. Can we remove them entirely OR just do not install them during build process for Linux platform in case they are necessary for non-Linux platform? Or if this is mistake and if they are necessary maybe it's good idea to document this and add small note somewhere.

Expected behavior
Silent, satisfied linters.

Environment

  • OS: Fedora
  • Desktop environment: DE-agnostic issue (i hope)
  • Crow Translate version: 2.11.1
@tim77 tim77 added the bug Something isn't working label May 24, 2024
@tim77 tim77 changed the title Non-commin icon res files Non-common icon res files May 24, 2024
@Shatur
Copy link
Member

Shatur commented May 24, 2024 •
edited
Loading

I'm fine with removing them! Feel free to open a PR.

@VolkMilit
Copy link
Contributor

AFAIK it is used by Windows build. See:

44x44 - app icon
150x150 - medium tile
310x310 - large tile

So we definatly should keep them.

@Shatur Shatur closed this as completed Jun 4, 2024
@Shatur Shatur reopened this Jun 4, 2024
@tim77
Copy link
Contributor Author

tim77 commented Jun 4, 2024

@VolkMilit thanks for info. So would be better to make it conditional and do not install them during build process just for Linux platform. I'll try to submit PR but no ETA yet unfortunately. Not critical, but nice to fix in future.

@VolkMilit
Copy link
Contributor

@tim77 #689 already done :)

@Shatur Shatur linked a pull request Jun 4, 2024 that will close this issue
Icons 44x44, 150x150, 310x310 should be only build on Windows #689
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Icons 44x44, 150x150, 310x310 should be only build on Windows crow-translate/crow-translate
3 participants
@tim77 @VolkMilit @Shatur