New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker #260

Merged
merged 1 commit into from Apr 10, 2015

Conversation

3 participants
@vuntz
Member

vuntz commented Mar 12, 2015

No description provided.

@vuntz vuntz changed the title from Add suppor for docker to Add support for docker Mar 12, 2015

@@ -81,6 +81,7 @@ workers = <%= [node["cpu"]["total"], 2, 4].sort[1] %>
# Supported values for the 'container_format' image attribute
#container_formats=ami,ari,aki,bare,ovf,ova
container_formats=ami,ari,aki,bare,ovf,ova<%= @use_docker ? ",docker" : "" %>

This comment has been minimized.

@tboerger

tboerger Mar 16, 2015

Contributor

I think it should be nicer to have it as an attribute array and join it within the config, what do you think?

@tboerger

tboerger Mar 16, 2015

Contributor

I think it should be nicer to have it as an attribute array and join it within the config, what do you think?

This comment has been minimized.

@vuntz

vuntz Apr 3, 2015

Member

For the record, the reason to not use an attribute array is that we want to easily be able to compare the values we don't change (ami,ari,aki,bare,ovf,ova) with what is in the upstream config file.

@vuntz

vuntz Apr 3, 2015

Member

For the record, the reason to not use an attribute array is that we want to easily be able to compare the values we don't change (ami,ari,aki,bare,ovf,ova) with what is in the upstream config file.

@tboerger

This comment has been minimized.

Show comment
Hide comment
@tboerger

tboerger Mar 16, 2015

Contributor

Small nitpic but LGTM

Contributor

tboerger commented Mar 16, 2015

Small nitpic but LGTM

@jsuchome

This comment has been minimized.

Show comment
Hide comment
@jsuchome

jsuchome Apr 2, 2015

Contributor

+1, tested and adding docker image to glance works

Contributor

jsuchome commented Apr 2, 2015

+1, tested and adding docker image to glance works

vuntz added a commit that referenced this pull request Apr 10, 2015

@vuntz vuntz merged commit 056958b into crowbar:master Apr 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment