This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Make role attributes work, and add some to play around with in CB 2.0 [5/8] #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorLowther
restored the
pull-req-master-cd953079fcc42015c6552d4b6d190cc54e898308
branch
|
+2 |
ravolt
added a commit
that referenced
this pull request
Dec 6, 2013
…42015c6552d4b6d190cc54e898308 #70 Merged by devtool for ravolt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Attrib.get smart. Instead of passing a blob of JSON, it now
accepts the object it should try to work with. This centralizes the
logic around what fields in an object are valid places to get
attributes from, and will fail hard if you pass it something that
should not work with the attribute system.
Add matching Attrib.set methods. This provides an abstract interface
for setting attributes on objects that matches the use of
Attrib.get.
Add some attributes to various nodes to lay the groundwork for
adding logic to the annealer to make it consiter attribute visibility.
Numerous trivial cleanups to make things work with the above changes.
crowbar.yml | 6 ++++++
1 file changed, 6 insertions(+)
Crowbar-Pull-ID: cd953079fcc42015c6552d4b6d190cc54e898308
Crowbar-Release: development