upgrade: Move "crowbar_upgrade_step" attribute to node role #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the previous "node_upgrade_state" change this is done to prevent a race condition with a chef-client running on the node that might overwrite "crowbar_wall".
|
This is largely untested and requires changes on the cloud 6 branch as well as crowbar-ha. |
nicolasbock
approved these changes
Feb 8, 2017
rhafer
added a commit
to rhafer/crowbar-core
that referenced
this pull request
Feb 8, 2017
This is a partial backport of crowbar#1080 to stable/3.0 Note: This should not change any pieces related to the upgrade from tex to stable/3.0 to avoid breaking that. That's why the there are still a lot of reference to crowbar_wall["crowbar_upgrade_step"] left.
jsuchome
reviewed
Feb 8, 2017
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| return unless node[:platform_family] == "suse" | |||
|
|
|||
| upgrade_step = node["crowbar_wall"]["crowbar_upgrade_step"] || "none" | |||
| upgrade_step = node["crowbar_upgrade_step"] || "none" | |||
There was a problem hiding this comment.
Don't we need node["crowbar"] here?
There was a problem hiding this comment.
@jsuchome I think you are right.
rhafer
added a commit
to rhafer/crowbar-core
that referenced
this pull request
Feb 9, 2017
This is a partial backport of crowbar#1080 to stable/3.0 Note: This should not change any pieces related to the upgrade from tex to stable/3.0 to avoid breaking that. That's why the there are still a lot of reference to crowbar_wall["crowbar_upgrade_step"] left.
rhafer
added a commit
to rhafer/crowbar-core
that referenced
this pull request
Feb 9, 2017
This is a partial backport of crowbar#1080 to stable/3.0 Note: This should not change any pieces related to the upgrade from tex to stable/3.0 to avoid breaking that. That's why the there are still a lot of reference to crowbar_wall["crowbar_upgrade_step"] left.
jsuchome
approved these changes
Feb 9, 2017
|
For the record: that "upgrade" gating job cannot pass right now, as it would require additional 2 PR's (one on Cloud6 side) as well as pending fix for crowbarctl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the previous "node_upgrade_state" change this is done to
prevent a race condition with a chef-client running on the node that
might overwrite "crowbar_wall".