prevent crowbar batch from locking itself and the user out #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2015 11:13
If crowbar batch is used to export the crowbar proposal from one cloud and apply it to another, it will change the machine-install user's password, which is typically the one used to run crowbar batch. This would break any future HTTP digest authentications against the Crowbar REST API, including ones invoked immediately after the change, by the still running crowbar batch process. So if the user inadvertently attempts to change the password they're currently relying on, simply output a warning and ignore the attempt. (cherry picked from commit 183dd52f8f292d26a37664b903118b6056b61725)
e.g. if the username/password is wrong, it needs to be clear to the user that authentication failed. (cherry picked from commit d6e9a9a347c95e16c3aa5429b45a9d354434d3c5)
|
+1 and this already got two +1s as crowbar/barclamp-crowbar#1336 |
|
+1 |
jsuchome
added a commit
that referenced
this pull request
Sep 15, 2015
prevent crowbar batch from locking itself and the user out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally crowbar/barclamp-crowbar#1336