Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2187 V5 pronoun variable #2341

Merged
merged 4 commits into from
Jan 6, 2024
Merged

#2187 V5 pronoun variable #2341

merged 4 commits into from
Jan 6, 2024

Conversation

Firebottle
Copy link
Collaborator

@Firebottle Firebottle commented Jan 6, 2024

handles #2187

Description of the Change

Creates a new replace variable that can pull pronoun information for a user from the pronoun site. It also allows the user to put in a fallback, as well as define which pronoun to use from a set like "They/Them".

$pronouns[$username, 0, they/them] = Returns "she/her" with fallback of "they/them"
$pronouns[$username, 1, they] = Returns "she" with fallback of "they"
$pronouns[$username, 2, them] = Returns "her" with fallback of "them"

Applicable Issues

This won't cover every single possible combination of pronouns people might need of course. For example "his" is not something on the pronoun site, so people will need to get creative to cover some edge cases.

Testing

  • Create a command in firebot using the new variable.
  • Run command in chat.
  • Try putting gibberish in for the username to make sure fallbacks are used.

@Firebottle Firebottle self-assigned this Jan 6, 2024
@Firebottle Firebottle closed this Jan 6, 2024
@Firebottle Firebottle reopened this Jan 6, 2024
@Firebottle Firebottle changed the base branch from master to v5 January 6, 2024 17:06
@Firebottle
Copy link
Collaborator Author

You can tell its been awhile. Opened with the base set to master, saw a bunch of extra commits, freaked out, closed the request... reopened when I realized I'm silly.

Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!!

@ebiggz ebiggz enabled auto-merge January 6, 2024 21:05
@ebiggz ebiggz merged commit 5544780 into v5 Jan 6, 2024
2 checks passed
@ebiggz ebiggz deleted the v5-pronoun-variable branch January 6, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants