-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add $effectQueueLength variable #2533
base: v5
Are you sure you want to change the base?
Conversation
…s api on getItem call
@@ -101,7 +101,7 @@ class EffectQueueManager extends JsonDbManager { | |||
} | |||
|
|||
item.queue = effectQueueRunner.getQueue(itemId); | |||
|
|||
item.length = item.queue.length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding this so the express api also has easy access to this value. Its present when calling for all queues but not individual queues so assume just a small oversight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I implemented that originally, the paradigm was "fetch all queues, get length. Fetch specific queue, get the array of items instead for more advanced use"
the intention there was that if you needed the length, you'd get it from the array as the array is already present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely get it, I'm adding it for the less capable tools that can fetch against the api but only take the json key and don't permit any type of count/logic capabilities.
Description of the Change
I've added a new text variable "effectQueueLength" as a utility variable. This variable takes in a queue name
Applicable Issues
#2513
Testing
Screenshots
Selecting the variable:
Primary use case:
Bad queue case: