Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VueImg breaks SEO fetching. #24

Closed
kherona opened this issue Oct 5, 2017 · 2 comments
Closed

VueImg breaks SEO fetching. #24

kherona opened this issue Oct 5, 2017 · 2 comments

Comments

@kherona
Copy link

kherona commented Oct 5, 2017

Hello,

I have recently published a website and while I was trying to get goodle to crawl (fetch as Google) my page was returning blank. I started removing components one at a time to see what was going wrong until, the only fix was to remove Vue.use(VueImg), it seems somewhere along the lines you are changing some DOM attributes that upsets SEO bots.

You can test any vue project with VueImg on:
https://technicalseo.com/seo-tools/fetch-render/

Check any project that has vueImg in it, i.e: https://v-img.review/
Then test the bots with other vuejs project. i.e: https://vuejs.mikesprague.me/shopping-cart/

I hope this can be a quick fix, otherwise I'll have to use other tool for images.

Thanks

@fahrenq fahrenq added the bug label Oct 5, 2017
@fahrenq
Copy link
Contributor

fahrenq commented Oct 5, 2017

Hello!

Thank you very very much for reporting the issue. It's very important!
Unfortunately, I've spend around 2 hours and couldn't fix this bug.
I empirically found out that lines:

const Screen = Vue.extend(ImgScreen);
vm = window.vueImg = new Screen().$mount('#imageScreen');

Don't affect the issue. At least directly.
Will try to fix it asap.

Thanks.

fahrenq added a commit that referenced this issue Oct 19, 2017
fahrenq added a commit that referenced this issue Oct 19, 2017
[0.1.3] Fixed SEO bug under #24 issue
@fahrenq
Copy link
Contributor

fahrenq commented Oct 19, 2017

Can't imagine I found this. @kherona, please, if you have time, can you update to the version 0.1.4 and test it one more time on your site?
At least it works with https://v-img.review/
Thank you very very much for reporting this bug.

@fahrenq fahrenq closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants