[WIP] Code Overhaul #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,22 +0,0 @@ | |||
| # CF Revision Manager Changelog | |||
There was a problem hiding this comment.
We can't trash the changelog. In fact, this branch will warrant a new entry to explain the total overhaul that is taking place in what will become version 2.0.0.
| <div class="wrap"> | ||
| <h2><?php _e( 'CF Revision Manager', 'cfrm' ); ?></h2> | ||
| <?php | ||
| if ( ! count( $keys ) ) { |
There was a problem hiding this comment.
I would personally write this condition as if ( empty( $keys ) ) {. There's no performance or syntax reason for the change, it's purely a stylistic preference.
|
General comment for code throughout: there are two different prefixes in use across this codebase, |
|
That's exactly what I was looking for 👍 Is this pull request going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to totally refactor and rebuild the original codebase to work with WP 4.4+
For #3