Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HttpRequestMessage instance per request #101

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

PatrykPlewaOfficial
Copy link
Contributor

@PatrykPlewaOfficial PatrykPlewaOfficial commented Feb 8, 2023

Fixes the exception System.InvalidOperationException: The request message was already sent. Cannot send the same request message multiple times. when the HttpRequestMessage instance is being reused.

It's a breaking change
No longer a breaking change.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #101 (be1f074) into main (040e8c1) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   47.10%   46.75%   -0.35%     
==========================================
  Files         272      272              
  Lines        3603     3630      +27     
==========================================
  Hits         1697     1697              
- Misses       1906     1933      +27     
Impacted Files Coverage Δ
src/Crowdin.Api/CrowdinApiClient.cs 6.70% <0.00%> (-0.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PatrykPlewaOfficial PatrykPlewaOfficial changed the title fix: HttpClient instance per request fix: HttpRequestMessage instance per request Feb 8, 2023
@andrii-bodnar
Copy link
Member

@PatrykPlewaOfficial thanks a lot for your contribution!

@innomaxx please review it

@andrii-bodnar andrii-bodnar linked an issue Feb 8, 2023 that may be closed by this pull request
@PatrykPlewaOfficial PatrykPlewaOfficial marked this pull request as ready for review February 8, 2023 18:57
@innomaxx innomaxx merged commit 2383c79 into crowdin:main Feb 14, 2023
@PatrykPlewaOfficial PatrykPlewaOfficial deleted the fix/http-client-instance branch February 17, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpRequestMessage retries issue and HttpClient lifetime
3 participants