Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle includePreTranslatedStringsOnly parameter for AddTaskRequest #165

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat: Handle includePreTranslatedStringsOnly parameter for AddTaskRequest #165

merged 1 commit into from
Jul 18, 2023

Conversation

Riju-bak
Copy link
Contributor

@Riju-bak Riju-bak commented Jul 1, 2023

Related issue: #163

Description:
Crowdin-API's Add Task API now requires an includePreTranslatedStringsOnly parameter. crowdin-api-client-dotnet should thus be able to handle requests that contain this parameter within the body.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #165 (9806186) into main (f45d418) will increase coverage by 4.05%.
The diff coverage is 86.44%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   50.38%   54.43%   +4.05%     
==========================================
  Files         277      308      +31     
  Lines        3688     4790    +1102     
==========================================
+ Hits         1858     2607     +749     
- Misses       1830     2183     +353     
Impacted Files Coverage Δ
src/Crowdin.Api/CrowdinApiClient.cs 14.56% <ø> (+8.08%) ⬆️
src/Crowdin.Api/Glossaries/GlossaryExportStatus.cs 0.00% <0.00%> (ø)
src/Crowdin.Api/Glossaries/GlossaryImportStatus.cs 0.00% <0.00%> (ø)
...rowdin.Api/ProjectsGroups/EnterpriseProjectForm.cs 0.00% <0.00%> (ø)
...c/Crowdin.Api/ProjectsGroups/FileFormatSettings.cs 5.27% <0.00%> (-2.63%) ⬇️
.../Crowdin.Api/ProjectsGroups/ProjectSettingPatch.cs 78.27% <ø> (+3.27%) ⬆️
...wdin.Api/ProjectsGroups/StringsBasedProjectForm.cs 0.00% <0.00%> (ø)
...Crowdin.Api/Tasks/LanguageServiceTaskCreateForm.cs 0.00% <0.00%> (ø)
src/Crowdin.Api/Tasks/TaskCreateForm.cs 0.00% <0.00%> (ø)
src/Crowdin.Api/Tasks/VendorOhtTaskCreateForm.cs 0.00% <0.00%> (ø)
... and 49 more

... and 61 files with indirect coverage changes

@Riju-bak Riju-bak marked this pull request as ready for review July 3, 2023 15:21
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Riju-bak thank you!

@andrii-bodnar andrii-bodnar merged commit 1521d56 into crowdin:main Jul 18, 2023
6 checks passed
@Riju-bak
Copy link
Contributor Author

Glad I could help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Task API: new includePreTranslatedStringsOnly parameter
2 participants