Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ExportBundle - Invalid Content Type #168

Merged

Conversation

PatrickMNL
Copy link
Contributor

@PatrickMNL PatrickMNL commented Jul 18, 2023

fixes #166

@@ -136,7 +135,6 @@ public class CrowdinApiClient : ICrowdinApiClient
_rateLimiter = rateLimiter;
_retryService = retryService;

_accessToken = credentials.AccessToken;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable is not being used, might as wel remove it.

@PatrickMNL PatrickMNL changed the title ExportBundle - Invalid Content Type fix: ExportBundle - Invalid Content Type Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #168 (19ae6d8) into main (f45d418) will increase coverage by 4.05%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   50.38%   54.43%   +4.05%     
==========================================
  Files         277      308      +31     
  Lines        3688     4790    +1102     
==========================================
+ Hits         1858     2607     +749     
- Misses       1830     2183     +353     
Impacted Files Coverage Δ
src/Crowdin.Api/CrowdinApiClient.cs 14.56% <0.00%> (+8.08%) ⬆️
src/Crowdin.Api/Glossaries/GlossaryExportStatus.cs 0.00% <0.00%> (ø)
src/Crowdin.Api/Glossaries/GlossaryImportStatus.cs 0.00% <0.00%> (ø)
...rowdin.Api/ProjectsGroups/EnterpriseProjectForm.cs 0.00% <0.00%> (ø)
...c/Crowdin.Api/ProjectsGroups/FileFormatSettings.cs 5.27% <0.00%> (-2.63%) ⬇️
.../Crowdin.Api/ProjectsGroups/ProjectSettingPatch.cs 78.27% <ø> (+3.27%) ⬆️
...wdin.Api/ProjectsGroups/StringsBasedProjectForm.cs 0.00% <0.00%> (ø)
...Crowdin.Api/Tasks/LanguageServiceTaskCreateForm.cs 0.00% <0.00%> (ø)
src/Crowdin.Api/Tasks/TaskCreateForm.cs 0.00% <0.00%> (ø)
src/Crowdin.Api/Tasks/VendorOhtTaskCreateForm.cs 0.00% <0.00%> (ø)
... and 49 more

... and 61 files with indirect coverage changes

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PatrickMNL thank you!

@andrii-bodnar andrii-bodnar merged commit ab94316 into crowdin:main Jul 18, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BundleApiExector.ExportBundle responds 500 because it's not sending an expected Content-Type header.
2 participants