Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix webhook response serialization error #77

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

duyguyildirantekin
Copy link

fix for webhook response serialization error

@andrii-bodnar
Copy link
Member

Hi @duyguyildirantekin, thanks a lot for your contrinution! 🎉

@andrii-bodnar andrii-bodnar linked an issue Sep 20, 2022 that may be closed by this pull request
@andrii-bodnar
Copy link
Member

@duyguyildirantekin some checks have failed, please check this

@duyguyildirantekin
Copy link
Author

duyguyildirantekin commented Sep 20, 2022

me checks have failed, please check this

hi @andrii-bodnar ,
I am not familiar with the error, however, I investigated the error, and found this article, could you check this

@andrii-bodnar
Copy link
Member

@innomaxx could you please assist with this?

@innomaxx
Copy link
Collaborator

@innomaxx could you please assist with this?

Sure, thanks for the reminder.

@duyguyildirantekin
Copy link
Author

@andrii-bodnar @innomaxx is there a time assumption for merging this pull request?

@innomaxx
Copy link
Collaborator

@andrii-bodnar @innomaxx is there a time assumption for merging this pull request?

In progress, sorry for the delay

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #77 (b11c748) into main (9436af0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b11c748 differs from pull request most recent head ba6c947. Consider uploading reports for the commit ba6c947 to get more accurate results

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   31.87%   31.87%           
=======================================
  Files         244      244           
  Lines        3273     3273           
=======================================
  Hits         1043     1043           
  Misses       2230     2230           
Impacted Files Coverage Δ
src/Crowdin.Api/Webhooks/Webhook.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@innomaxx innomaxx merged commit 46e1211 into crowdin:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook.AddWebhook endpoint response serialization error
3 participants