Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improving request validation and client methods. #14

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

vorobeyme
Copy link
Collaborator

  • add a nil check to the Validate() method
  • replace int64 with int in client methods and schemas
  • replace bool with *bool in requests to allow null values
  • update Patch() method (client) to handle different body types and perform validation
  • improve null check in ListOptionsProvider
  • move client schemas to the model package
  • add helper functions etc.

- add a nil check to the Validate() method
- replace int64 with int in client methods and schemas
- replace bool with *bool in requests to allow null values
- update Patch() method (client) to handle different body types and perform validation
- improve null check in ListOptionsProvider
- add helper functions etc
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 221 lines in your changes are missing coverage. Please review.

Project coverage is 2.49%. Comparing base (c025a0d) to head (d65c099).

Files Patch % Lines
crowdin/crowdin.go 0.00% 33 Missing ⚠️
crowdin/model/translations.go 0.00% 29 Missing ⚠️
crowdin/model/source_files.go 0.00% 19 Missing ⚠️
crowdin/model/source_strings.go 0.00% 18 Missing ⚠️
crowdin/projects.go 0.00% 15 Missing ⚠️
crowdin/model/string_translations.go 0.00% 14 Missing ⚠️
crowdin/model/errors.go 0.00% 13 Missing ⚠️
crowdin/model/projects.go 0.00% 12 Missing ⚠️
crowdin/model/branches.go 0.00% 9 Missing ⚠️
crowdin/source_files.go 0.00% 9 Missing ⚠️
... and 12 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #14      +/-   ##
========================================
- Coverage   2.63%   2.49%   -0.14%     
========================================
  Files         22      23       +1     
  Lines        990    1046      +56     
========================================
  Hits          26      26              
- Misses       962    1018      +56     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 357d54a into main Mar 28, 2024
2 checks passed
@andrii-bodnar andrii-bodnar deleted the feat/improvements branch March 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants