Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing StringId param in add_string_comment #53

Closed
easysugar opened this issue Oct 22, 2022 · 4 comments · Fixed by #54
Closed

Missing StringId param in add_string_comment #53

easysugar opened this issue Oct 22, 2022 · 4 comments · Fixed by #54
Assignees
@ShivamGarg2910
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@easysugar
Copy link

crowdin-api-client-python/crowdin_api/api_resources/string_comments/resource.py

Line 79 in 1951497

"text": text,

There're should be a param StringId due to add_string_comment
@andrii-bodnar andrii-bodnar added bug Something isn't working good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest labels Oct 22, 2022
@ShivamGarg2910
Copy link
Contributor

Hi @easysugar, please assign it to me.

@ShivamGarg2910
Copy link
Contributor

@andrii-bodnar, curious on how will the stringId get generated?
Do i need to get total no. of comments and then increment count?

@andrii-bodnar
Copy link
Member

andrii-bodnar commented Oct 22, 2022 •
edited
Loading

@ShivamGarg2910 the stringId could be received from the List Strings API method.

Do i need to get total no. of comments and then increment count?

No, you just need to add this parameter to the add_string_comment method and pass it to the request

@ShivamGarg2910
Copy link
Contributor

Done

@andrii-bodnar andrii-bodnar linked a pull request Oct 23, 2022 that will close this issue
Added stringId as param in string comments #54
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivamGarg2910 ShivamGarg2910

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added stringId as param in string comments ShivamGarg2910/crowdin-api-client-python
3 participants
@ShivamGarg2910 @andrii-bodnar @easysugar